Fix Add Contact - #303
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the “+ New contact” button behavior in the contacts pane to open the Add Contact modal using a component-based solid-ui dialog invocation, addressing the reported “Add Contact” button issue.
Changes:
- Replace the Lit
htmltemplate dialog invocation withUI.showDialog(AddContactModal, { props: ... }). - Swap the side-effect-only modal import for an explicit default import of
AddContactModal. - Bump package version from
3.2.1-5to3.2.1-6.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/contactsPane.js | Switches Add Contact dialog opening from a Lit template to a component + props approach. |
| package.json | Increments package version for the release containing the fix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Prompt: add a test for Add Contact Dialog Co-authored-by: GPT-5.4 Mini <gpt-5.4-mini@openai.com>
SharonStrats
force-pushed
the
fix/add-contact
branch
from
August 7, 2026 21:56
47332e7 to
cfda68f
Compare
m5x5
approved these changes
Aug 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixed the problem with the Add Contact button.